-
Notifications
You must be signed in to change notification settings - Fork 26
Add lazy version of shared_datadir #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Seems reasonable, thanks @nyoma-diamond! Could you please provide tests for the new fixture? |
Yup sure thing :) |
@nicoddemus Hopefully those tests are sufficient? It's worth noting that I've made an explicit design choice (admittedly somewhat arbitrarily, but I think makes sense) to have That said, if you disagree with the design choice, it's an easy change. |
I think the presented new behaviour for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I will merge/release tomorrow to give others a chance to review. 👍
|
A quick-and-dirty implementation of the lazy datadir that uses a shared data directory mimicking
shared_datadir
.This is very useful for when there are a lot of data files and organizing them for every single test / test file instead of using a single shared data directory is very cumbersome, but copying all of the files each time
shared_datadir
is used induces lots of excessive copying/file usage.