fix(replays): Cap segment_id size to u16 #2434
Merged
+36
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iker-barriocanal
approved these changes
Aug 29, 2023
Co-authored-by: Joris Bayer <[email protected]>
Co-authored-by: Iker Barriocanal <[email protected]>
cmanallen
added a commit
that referenced
this pull request
Apr 3, 2025
Due to a comedy of errors the u16 max validation was inadvertently removed. This PR re-adds it. This validation was present for most of replays history. Previous PRs on the subject (not necessary to read -- put here to explain the situation for future readers should this issue come back). #2434 #3280 #3961 #3984
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotated<u16>is not possible so I'm manually checking if the u64 type is within the bounds of a u16.#skip-changelog