feat(server): parametrize dsc transaction #3141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBS1996
commented
Feb 19, 2024
| if !self.name_config.rules.is_empty() { | ||
| self.apply_transaction_rename_rule(&mut event.transaction); | ||
| } | ||
| normalize_transaction_name(&mut event.transaction, self.name_config.rules); |
There was a problem hiding this comment.
extracted for re-use with dsc
TBS1996
commented
Feb 19, 2024
| /// | ||
| /// Note: we add `/` at the end of the transaction name if there isn't one, to make sure that | ||
| /// patterns like `/<something>/*/**` where we have `**` at the end are a match. | ||
| pub fn apply_transaction_rename_rules( |
There was a problem hiding this comment.
unchanged, just moved
TBS1996
commented
Feb 20, 2024
jjbayer
requested changes
Feb 20, 2024
| &self, | ||
| state: &mut ProcessEnvelopeState<G>, | ||
| ) -> Result<(), ProcessingError> { | ||
| let project_state = Arc::clone(&state.project_state); |
There was a problem hiding this comment.
In the current setup, yes, because we need mutable reference to ProcessEnvelopeState to mutate the envelope, and the rules are inside the project state, so we'd get a cannot borrow mutable because its also borrowed as immutable error
Co-authored-by: Joris Bayer <[email protected]>
jjbayer
reviewed
Feb 21, 2024
| envelope = Envelope() | ||
| transaction_event, trace_id, _ = _create_transaction_item() | ||
| envelope.add_transaction(transaction_event) | ||
| _add_trace_info(envelope, trace_id, public_key, transaction=original_transaction) |
There was a problem hiding this comment.
We should add a second project config that contains the txNameRules and pass its project key here, to test that the normalization uses the correct config.
TBS1996
commented
Feb 21, 2024
| sampling_config["config"]["txNameRules"] = [ | ||
| { | ||
| "pattern": pattern, | ||
| "expiry": "3022-11-30T00:00:00.000000Z", |
There was a problem hiding this comment.
note: test will fail 998 years from now
jjbayer
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2068
Parametrizes the root transaction of a DSC so that trace rules can match on the parametrized version of transaction names