fix(spans): Always count span usage #3719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phacops
reviewed
Jun 12, 2024
| // If there are any spans in the system, extract the usage metric for them: | ||
| let any_spans = features.has(Feature::ExtractSpansFromEvent) | ||
| || features.has(Feature::StandaloneSpanIngestion) | ||
| || features.has(Feature::ExtractCommonSpanMetricsFromEvent); |
There was a problem hiding this comment.
You could add Feature::ExtractAddonsSpanMetricsFromEvent as well even though it's meant to be enabled only if common is enabled.
phacops
approved these changes
Jun 12, 2024
iker-barriocanal
approved these changes
Jun 12, 2024
| pub fn as_str(&self) -> Option<&'a str> { | ||
| match self { | ||
| Self::String(value) => Some(value), | ||
|
|
jjbayer
added a commit
that referenced
this pull request
Jun 12, 2024
#3719 enabled `c:spans/usage@none` for plans that do not extract other span metrics. We also need to allow the namespace otherwise they will be dropped with outcome `filtered:disabled-namespace`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3633 introduced separate feature flags for span extraction and span metrics, but this meant that there was no usage metric for spans that were extracted without common span metrics. We need the usage metric for accounting purposes.