fix(otlp): update op/description mapping #4505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update incoming OTLP span `name` to write to spans' `op` field instead of `description`. If a `sentry.description` attribute is given, write that to the spans' `description` field. The intended product behaviour is: - product functionality that depends on specific `op` values/formatting will be removed (replaced with `category`, which already exists but will be generated from span attributes instead of `op` - PR to follow) - with that removed, `op` and `name` have the same semantics and use cases and will be made equivalent - `description` will remain as it is today, to either be passed explicitly as `sentry.description` in attributes or generated by the system (PR to follow) Sentry's POTel SDKs currently map `name` to `description` in the SDK. This will eventually be changed to be in line with the above logic when they update to an OTLP span-based transport.
|
Setting as draft to prioritize the span category PR - based on the integration test failures, that one should go in first to minimize test churn. |
Dav1dde
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update incoming OTLP span
nameto write to spans'opfield instead ofdescription. If asentry.descriptionattribute is given, write that to the spans'descriptionfield.For background, this change will align with the rest of the product by the time this OTLP endpoint is shipped:
opvalues/formatting will be removed (replaced withcategory, which already exists as a Sentry tag but will be generated from span attributes instead ofop- PR to follow)opandnamewill have the same semantics and use cases and will be used interchangeably as "name" across the productdescriptionvalues being set (e.g. queries fordbspans) will be removed and replaced with references to explicit attributes (e.g.db.query.text)descriptionwill remain as extra context to augment span display in the trace view/explore, to either be passed explicitly assentry.descriptionin attributes or (in most cases) generated by the system - PR to followSentry's POTel SDKs currently map
nametodescriptionin the SDK. This will eventually be changed to be in line with the above logic when they update to an OTLP span-based transport.