Skip to content

Conversation

tobias-wilfert
Copy link
Member

@tobias-wilfert tobias-wilfert commented Feb 27, 2025

Our images are currently only tagged with the sha of their release, it would be nice to also have some tagged with the version, this PR tries to duplicate the logic found in sentry-cli for this and adapt it to our multi-arch builds.


Still need to check during the next release on the 15th that the release triggers work correctly, but the internal logic works
image

Fixes: #4517

@tobias-wilfert tobias-wilfert requested a review from a team February 28, 2025 08:17
@tobias-wilfert tobias-wilfert marked this pull request as ready for review February 28, 2025 08:17
@tobias-wilfert tobias-wilfert requested a review from a team as a code owner February 28, 2025 08:17
@tobias-wilfert tobias-wilfert self-assigned this Feb 28, 2025
@tobias-wilfert tobias-wilfert merged commit 49e2e4f into master Mar 3, 2025
25 checks passed
@tobias-wilfert tobias-wilfert deleted the tobias-wilfert/feat/tag-image-with-version branch March 3, 2025 10:31
untitaker pushed a commit to getsentry/snuba that referenced this pull request Mar 25, 2025
Similar work with these PRs:
- getsentry/relay#4532
- getsentry/symbolicator#1635

While also trying to provide a solution (or at least an alternative) for
this issue: getsentry/self-hosted#3593


### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
BYK pushed a commit to getsentry/vroom that referenced this pull request Jun 12, 2025
Similar work with these PRs:

- getsentry/relay#4532
- getsentry/symbolicator#1635
- getsentry/snuba#6997
- getsentry/sentry#88181

While also trying to provide a solution (or at least an alternative) for this issue: getsentry/self-hosted#3593


### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
BYK added a commit to getsentry/sentry that referenced this pull request Jun 13, 2025
Similar work with these PRs:

- getsentry/relay#4532
- getsentry/symbolicator#1635
- getsentry/snuba#6997

While also trying to provide a solution (or at least an alternative) for
this issue: getsentry/self-hosted#3593

### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.

---------

Co-authored-by: Burak Yigit Kaya <[email protected]>
billyvg pushed a commit to getsentry/sentry that referenced this pull request Jun 18, 2025
Similar work with these PRs:

- getsentry/relay#4532
- getsentry/symbolicator#1635
- getsentry/snuba#6997

While also trying to provide a solution (or at least an alternative) for
this issue: getsentry/self-hosted#3593

### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.

---------

Co-authored-by: Burak Yigit Kaya <[email protected]>
andrewshie-sentry pushed a commit to getsentry/sentry that referenced this pull request Jun 19, 2025
Similar work with these PRs:

- getsentry/relay#4532
- getsentry/symbolicator#1635
- getsentry/snuba#6997

While also trying to provide a solution (or at least an alternative) for
this issue: getsentry/self-hosted#3593

### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.

---------

Co-authored-by: Burak Yigit Kaya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release official images using ghcr.io
3 participants