feat(relay): expose service utilization metrics in autoscaling endpoint #4543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
approved these changes
Mar 4, 2025
…aling # Conflicts: # CHANGELOG.md
Dav1dde
approved these changes
Mar 5, 2025
Comment on lines
+67
to
+71
| fn extract_service_name(full_name: &str) -> &str { | ||
| full_name | ||
| .rsplit_once(':') | ||
| .map(|(_, s)| s) | ||
| .unwrap_or(full_name) |
There was a problem hiding this comment.
Is there a problem with keeping the full name?
There was a problem hiding this comment.
I did this for two reasons:
- Without the structure present in the full name we can refactor the location of a service without breaking or having to touch the metric
- PromQL queries have less noise in them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the autoscaling endpoint by adding service utilization metrics with the service name as the label.