Skip to content

Conversation

tobias-wilfert
Copy link
Member

@tobias-wilfert tobias-wilfert commented Mar 6, 2025

Some initial logic for the new playstation endpoint.

Fixes: #95

Copy link
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add integration test, make sure we assert the current behaviour.

@tobias-wilfert tobias-wilfert self-assigned this Mar 12, 2025
@tobias-wilfert tobias-wilfert requested a review from Dav1dde March 18, 2025 16:32
Comment on lines 92 to 93
// TODO: Check if this even has an effect since we will always have a multipart message.
// Looking at the minidump endpoint seems like multipart bypasses this.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have misunderstood what this is trying to achieve since it seems to only set the limit for an individual file in the multipart form. That is if I set it to -1 the size of a file (in the tests I have a test for that) it fails but sending the file twice with different names in the multipart form does not trigger this if the limit is size of the individual file +1.

@tobias-wilfert tobias-wilfert changed the title WIP: Playstation endpoint feat(processor): Playstation endpoint Mar 19, 2025
@tobias-wilfert tobias-wilfert marked this pull request as ready for review March 19, 2025 16:50
@tobias-wilfert tobias-wilfert requested a review from a team as a code owner March 19, 2025 16:50
Co-authored-by: David Herberth <[email protected]>
@tobias-wilfert tobias-wilfert merged commit bb90bcc into master Mar 20, 2025
25 checks passed
@tobias-wilfert tobias-wilfert deleted the tobis-wilfert/feat/add-playstation-endpoint branch March 20, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants