feat: custom switch attachment expansion #4566
Conversation
| @@ -0,0 +1,390 @@ | |||
| //! Nintendo Switch processor related code. | |||
| //! | |||
| //! These functions are included only in the processing mode. | |||
There was a problem hiding this comment.
Can you maybe add better docs on this module to explain what is the dying message and why it is used, might be helpful to future readers.
There was a problem hiding this comment.
I've just changed the first line of the expand() function header to say /// Expands Nintendo Switch crash-reports.. I don't believe we can add more details since this information is not public.
There was a problem hiding this comment.
It would be nice to make the dying message format public, either so we can link to it from here, or actually describe the format in Relay.
Any change to the format made must be first made in Relay anyways.
Co-authored-by: Riccardo Busetti <[email protected]>
|
Haven't taken a look at the changes yet, do we have an example 'real' dying message we can use for an integration test? We should definitely have at least one integration test which asserts Relay does the right thing (preferably more). |
not yet, i'm working on the SDK implementation in parallel and will update once I have one.
where would these go in the repo? |
You can put them into |
|
@Dav1dde I've added the integration test. Do you mind having another look at the PR? |
| @@ -0,0 +1,390 @@ | |||
| //! Nintendo Switch processor related code. | |||
| //! | |||
| //! These functions are included only in the processing mode. | |||
There was a problem hiding this comment.
It would be nice to make the dying message format public, either so we can link to it from here, or actually describe the format in Relay.
Any change to the format made must be first made in Relay anyways.
Co-authored-by: David Herberth <[email protected]>
We're adding a new SDK for Nintendo Switch & it requires that the attachment sent on crashes is parsed and expanded into the outer envelope.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.