feat: Make default Apple device class high #4609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the default device class to high for iPhones and iPads. We have an extensive list of these devices, which are well-known. If a device is not on this list, it must be a new one. Previously, we set the device class to unknown until we manually update this list. Now, the default is high.
Dav1dde
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default device class to high for iPhones and iPads. We have an extensive list of these devices, which are well-known. If a device is not on this list, it must be a new one. Previously, we set the device class to unknown until we manually update this list. Now, the default is high.
This came up while investigating getsentry/sentry#68258.