ref(relay): Bump sysinfo library version #4613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
approved these changes
Mar 25, 2025
Cargo.toml
Outdated
Comment on lines
186
to
188
| # This dependency was added through git since we are experimenting with a fork of sysinfo which adds additional | ||
| # capabilities of reading cgroups memory stats. Such stats are used in Relay to correctly determine memory usage. | ||
| sysinfo = { git = "https://github.com/getsentry/sysinfo.git", rev = "e2e5d530600f96bdd79652c856918da23e5dd938" } | ||
| sysinfo = { git = "https://github.com/getsentry/sysinfo.git", rev = "15b3be3273ba286740122fed7bb7dccd2a79dc8f" } |
There was a problem hiding this comment.
Since the PR is already merged, we can link directly to the upstream repo, update the comment to mention that we're just waiting for a release?
There was a problem hiding this comment.
Yes, I already added this to the PR but will also mention in code. I also prepared a ticket: https://github.com/getsentry/team-ingest/issues/685
There was a problem hiding this comment.
It seems to not work if I omit rev or just add branch = "master". I have no idea why :/
loewenheim
added a commit
that referenced
this pull request
May 28, 2025
The fix implemented in GuillaumeGomez/sysinfo#1488 has been released as part of version 0.35.0. Therefore we update `sysinfo` to the current version, 0.35.1. See #4613.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the
sysinfolibrary version to the latest commit added by the PR (GuillaumeGomez/sysinfo#1488).We should not forget to update to a stable version once the changes made in the PR mentioned above are added to the release.
Closes: #4059