feat(spooler): Add configuration check based on memory size #4617
+80
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iambriccardo
changed the title
Dav1dde
reviewed
Mar 27, 2025
CHANGELOG.md
Outdated
| @@ -20,6 +20,7 @@ | |||
| - Extract transaction breakdowns into measurements. ([#4600](https://github.com/getsentry/relay/pull/4600)) | |||
| - Expose worker pool metrics in autoscaler endpoint ([#4605](https://github.com/getsentry/relay/pull/4605)) | |||
| - Bump the revision of `sysinfo` to the revision at `15b3be3273ba286740122fed7bb7dccd2a79dc8f`. ([#4613](https://github.com/getsentry/relay/pull/4613)) | |||
| - Add additional check of the `Config` when starting relay. ([#4617](https://github.com/getsentry/relay/pull/4617)) | |||
There was a problem hiding this comment.
Maybe something like:
Suggested change
| - Add additional check of the `Config` when starting relay. ([#4617](https://github.com/getsentry/relay/pull/4617)) | |
| - Validate the spooling memory configuration on startup. ([#4617](https://github.com/getsentry/relay/pull/4617)) |
Dav1dde
approved these changes
Mar 27, 2025
k-fish
pushed a commit
that referenced
this pull request
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds dynamic config validation that makes sure that the batch size bytes used in the spooler is configured correctly. In case of incorrect configuration the system would deadlock.