feat(spans): Extract searchable contexts into span tags for segment spans #4651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shruthilayaj
changed the title
loewenheim
reviewed
Apr 10, 2025
| @@ -239,6 +239,61 @@ pub struct SentryTags { | |||
| #[metastructure(field = "device.class")] | |||
| pub device_class: Annotated<String>, | |||
| // Mobile OS the transaction originated from(String). | |||
There was a problem hiding this comment.
This comment got separated from its field.
shruthilayaj
requested review from
loewenheim
and removed request for
loewenheim
loewenheim
approved these changes
Apr 10, 2025
shruthilayaj
deleted the
shruthi/feat/extract-searchable-contexts-into-spans
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are certain context fields we were extracting into tags for transactions, making them a searchable property.
We need to make these fields searchable for EAP spans as well. Only storing these tags on segment spans for now.
https://www.notion.so/sentry/EAP-Spans-Missing-Tags-from-Transactions-1828b10e4b5d8041b73dcbc92188c168