fix(otlp): add OTLP trace endpoint without trailing slash #4655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
approved these changes
Apr 8, 2025
|
Need to make sure Nginx allows that route as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We structured our OTLP endpoint URL to match the OTLP standard, but we added a trailing slash that isn't present in the spec. That causes OTLP clients that automatically apply the
/v1/tracessuffix to 404 when trying to reach Relay. Add a version without the trailing slash to match the spec.Out of an abundance of caution this PR keeps the version with the trailing slash just in case someone is using it (although there are no known clients).