feat(pii): allow pii scrubbing within all span sentry_tags #4698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
approved these changes
Apr 30, 2025
Dav1dde
approved these changes
Apr 30, 2025
Comment on lines
+36
to
+37
| assert event["spans"][0]["sentry_tags"]["user.geo.country_code"] == "**" | ||
| assert event["spans"][0]["sentry_tags"]["user.geo.subregion"] == "**" |
There was a problem hiding this comment.
While it makes sense, that means now Sentry will index ** as geo code 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables pii scrubbing on all
sentry_tagsvalues within spans. This is done by introducing a struct levelpiimetastructure attribute which is then used as the default for all fields without explicitpiiattributes.