Skip to content

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented May 6, 2025

Mostly done by hand:

  • #[no_mangle] -> #[unsafe(no_mangle)]
  • unsafe fn foo { ... some_unsafe_code() } -> unsafe fn foo { ... unsafe { some_unsafe_code() } } (mostly in FFI)
  • env::* is unsafe now, just put them into an unsafe block for now, this was already in 2021 unsafe, just not marked as such
  • Foo(ref mut bar) -> Foo(bar) (a lot of those)
  • Updated cbindgen (old version produced edition incompatible code)

@Dav1dde Dav1dde requested a review from a team as a code owner May 6, 2025 09:53
@Dav1dde Dav1dde force-pushed the dav1d/edition-2024 branch from 599bf34 to 53ece94 Compare May 6, 2025 09:56
@Dav1dde Dav1dde force-pushed the dav1d/edition-2024 branch from 53ece94 to 2de96cb Compare May 6, 2025 11:59
@Dav1dde Dav1dde force-pushed the dav1d/edition-2024 branch from 4f8031b to 16dac04 Compare May 6, 2025 13:09
@Dav1dde Dav1dde enabled auto-merge (squash) May 6, 2025 13:10
@Dav1dde Dav1dde merged commit 5b5e2b4 into master May 6, 2025
27 checks passed
@Dav1dde Dav1dde deleted the dav1d/edition-2024 branch May 6, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants