feat(config): Allow environment references in Relay configuration #4750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/env-var-config
branch
from
66b7264 to
0b25918
Compare
loewenheim
approved these changes
May 20, 2025
loewenheim
added a commit
to getsentry/symbolicator
that referenced
this pull request
Jun 11, 2025
This makes it possible to use environment variables in the config file, courtesy of serde-vars. Inspired by getsentry/relay#4750.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt at #4748 for #4647, now with version 0.2 (instead of 0.1).
serde-vars 0.2 is now more lenient in deserialization when it can (for strings and bytes) and the underlying deserializer supports it. This will fix the config issue with YAML configs, which broke self hosted CI/the self hosted default Kafka config.