fix(ourlogs): Do not overcount the outcome bytes #4786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-sentry
force-pushed
the
logs_outcome_double_counting
branch
from
89ec63f to
ecae62d
Compare
k-fish
approved these changes
Jun 2, 2025
| category: DataCategory::LogByte, | ||
| event_id: None, | ||
| outcome: Outcome::Accepted, | ||
| quantity: payload.len() as u32, |
There was a problem hiding this comment.
payload is the container here for anyone wondering why we have to do this
Dav1dde
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if we have a 17kb envelope with 100 logs in it, we will record 100 * 17kb of total usage to outcomes