Skip to content

Conversation

Litarnus
Copy link
Contributor

@Litarnus Litarnus commented Jun 12, 2025

This PR adds a configuration option to allow high cardinality tags, such as project id, in metrics.
High cardinality tags are prefixed with hc.. By default, it will always strip those tags.

ref INGEST-140

@Litarnus Litarnus marked this pull request as ready for review June 16, 2025 07:51
@Litarnus Litarnus requested a review from a team as a code owner June 16, 2025 07:51
@Dav1dde
Copy link
Member

Dav1dde commented Jun 17, 2025

This allows adding high cardinality tags to metrics which are removed at a central place instead of having to modify metrics calls individually.

What is your plan with this? The tags should be opt-in not opt-out, this config looks like it would be more for opt-out?

Exposing all this functionality doesn't seem like a great idea, if we don't have to. People can also filter on their statsd service or collector.

@Litarnus Litarnus changed the title feat(relay): allow removing tags from metrics feat(relay): add configuration option to allow high cardinality tags in metric calls Jun 18, 2025
@Litarnus Litarnus merged commit 073833c into master Jun 24, 2025
27 of 28 checks passed
@Litarnus Litarnus deleted the martinl/deny-metric-tags branch June 24, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants