Skip to content

feat: Introduce DeepValue trait #4838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: Introduce DeepValue trait #4838

wants to merge 1 commit into from

Conversation

loewenheim
Copy link
Contributor

We have some unfortunate chains of value calls specifically when dealing with Annotated<Attribute> (viz. the changes to v2_to_v1.rs). This introduces a helper trait DeepValue for cases like this, where we want to dig a Value out of a deeply nested structure.

#skip-changelog

@loewenheim loewenheim requested a review from a team as a code owner June 23, 2025 07:30
@loewenheim loewenheim mentioned this pull request Jun 23, 2025
Merged
@loewenheim
Copy link
Contributor Author

Closing in favor of #4839.

@loewenheim loewenheim closed this Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@loewenheim