Skip to content

Conversation

vgrozdanic
Copy link
Member

@vgrozdanic vgrozdanic commented Jun 25, 2025

AI spans were the ones where op prefix was ai., but that has recently changed, and now most of AI spans op starts with gen_ai.

This PR fixes that.

@vgrozdanic vgrozdanic requested a review from a team as a code owner June 25, 2025 13:09
@Dav1dde
Copy link
Member

Dav1dde commented Jun 25, 2025

There are more spots where we check for ai.*, it would be great if you can update all of them.

For example here:

let is_ai = RuleCondition::glob("span.op", "ai.*");

@vgrozdanic
Copy link
Member Author

There are more spots where we check for ai.*, it would be great if you can update all of them.

For example here:

let is_ai = RuleCondition::glob("span.op", "ai.*");

Thanks! I did search global search on ai. but missed that one

@vgrozdanic vgrozdanic force-pushed the vg/fix-ai-spans branch 2 times, most recently from 513e6ca to 9ba27a0 Compare June 25, 2025 13:26
@vgrozdanic vgrozdanic changed the title fix(ai): Fix check if AI span fix(ai): Consider gen_ai valid op prefix for AI spans Jun 25, 2025
@vgrozdanic vgrozdanic enabled auto-merge June 25, 2025 13:37
@vgrozdanic vgrozdanic added this pull request to the merge queue Jun 25, 2025
Merged via the queue into master with commit 6994d0e Jun 25, 2025
29 checks passed
@vgrozdanic vgrozdanic deleted the vg/fix-ai-spans branch June 25, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants