ref(server): Forward logs without extra serialization to Store #4875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/store-no-envelope
branch
from
0b202e4 to
96bf3f2
Compare
Dav1dde
force-pushed
the
dav1d/store-no-envelope
branch
from
96bf3f2 to
af25732
Compare
loewenheim
reviewed
Jun 30, 2025
loewenheim
approved these changes
Jul 1, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
#4875 was too ambitious, a split out from another PR which would address the issue surfacing now. The log byte counts are no longer correct as they aren't counted correctly anymore. This reverts the changes to the store processor made in the original PR, and introduces a new feature flag (which is not enabled anywhere = disabled), which toggles to the new behaviour. When the feature flag is disabled, it falls back to the old behaviour of serializing an envelope and forwarding that to the store, resulting in the old byte counts again. #skip-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now builds the log
TraceItemas part of the new processing pipeline and forwards it to the Store processor without having to serialize it first, just to deserialize it again.