feat(otlp): Serialize OTEL span array attributes to JSON #4930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
reviewed
Jul 11, 2025
Is this specified somewhere for Spans V2? |
gggritso
changed the title
gggritso
changed the title
|
@loewenheim whoa, I guess not! I made that assumption, but I guess we never actually discussed this. Since this PR deals exclusively with converting OTEL spans, I left mentions of |
loewenheim
approved these changes
Jul 11, 2025
Co-authored-by: Sebastian Zivota <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTLP supports array attributes, and there are many common semantic attributes that are expected to be arrays. Right now, we discard this information because we don't have system-level handling for arrays at all, and a proper solution is very hard.
For now, let's hack around this, and serialize array types to a JSON string, which is a common recommended approach by OTel when a protocol cannot support every data type.
Convert array attributes very early to strings, and then sends them along.