Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
df7dba7
chore(metrics): Disable span metrics
phacops Jul 11, 2025
9a804ec
Remove feature flags
phacops Jul 11, 2025
5841a87
Update snapshots
phacops Jul 11, 2025
8f19191
Remove unneded tests
phacops Jul 11, 2025
e431ebc
Remove more tests
phacops Jul 11, 2025
b1ca3cf
Add a CHANGELOG entry
phacops Jul 11, 2025
762596d
Remove reference to inexistent feature flag
phacops Jul 11, 2025
4d425eb
Fix test_rate_limit_spans_in_envelope
phacops Jul 11, 2025
619f0b5
Fix integration tests
phacops Jul 11, 2025
b33acb5
Fix more tests
phacops Jul 11, 2025
e59cb87
Fix test_dynamic_sampling
phacops Jul 11, 2025
f9482ca
Remove more references to span metrics in tests
phacops Jul 11, 2025
fd5259d
Restore transaction metrics extracted from spans
phacops Jul 14, 2025
b638447
Fix test_rate_limit_spans_in_envelope
phacops Jul 14, 2025
f5e39cf
Fix test_get_global_config
phacops Jul 14, 2025
b414c90
Fix test_transaction_metrics
phacops Jul 15, 2025
970896b
Deprecate features instead of removing them
phacops Jul 15, 2025
9d2baf6
Fix test_metric_bucket_encoding_dynamic_global_config_option
phacops Jul 15, 2025
4cbaa2b
Merge remote-tracking branch 'origin/master' into pierre/disable-span…
phacops Jul 15, 2025
6f22a67
Remove print
phacops Jul 15, 2025
eee7701
Fix test_dynamic_sampling
phacops Jul 15, 2025
7bed444
Merge branch 'master' into pierre/disable-span-metrics
phacops Jul 16, 2025
b6ac63e
Fix CHANGELOG entry
phacops Jul 16, 2025
208f723
Rename deprecated features and fix comments
phacops Jul 17, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog


## Unreleased

**Internal**:

- Disable span metrics. ([#4931](https://github.com/getsentry/relay/pull/4931))

## 25.7.0

**Features**:
Expand Down
1,304 changes: 196 additions & 1,108 deletions relay-dynamic-config/src/defaults.rs

Large diffs are not rendered by default.

22 changes: 9 additions & 13 deletions relay-dynamic-config/src/feature.rs
Original file line number Diff line number Diff line change
Expand Up @@ -80,16 +80,6 @@ pub enum Feature {
/// Serialized as `organizations:continuous-profiling-beta-ingest`.
#[serde(rename = "organizations:continuous-profiling-beta-ingest")]
ContinuousProfilingBetaIngest,
/// Enables metric extraction from spans for common modules.
///
/// Serialized as `projects:span-metrics-extraction`.
#[serde(rename = "projects:span-metrics-extraction")]
ExtractCommonSpanMetricsFromEvent,
/// Enables metric extraction from spans for addon modules.
///
/// Serialized as `projects:span-metrics-extraction-addons`.
#[serde(rename = "projects:span-metrics-extraction-addons")]
ExtractAddonsSpanMetricsFromEvent,
/// When enabled, spans will be extracted from a transaction.
///
/// Serialized as `organizations:indexed-spans-extraction`.
Expand Down Expand Up @@ -124,6 +114,14 @@ pub enum Feature {
/// Detect performance issues in the new standalone spans pipeline instead of on transactions.
#[serde(rename = "organizations:performance-issues-spans")]
PerformanceIssuesSpans,
/// This feature has deprecated and is kept for external Relays.
#[doc(hidden)]
#[serde(rename = "projects:span-metrics-extraction")]
DeprecatedExtractCommonSpanMetricsFromEvent,
/// This feature has been deprecated and is kept for external Relays.
#[doc(hidden)]
#[serde(rename = "projects:span-metrics-extraction-addons")]
DeprecatedExtractAddonsSpanMetricsFromEvent,
/// Forward compatibility.
#[doc(hidden)]
#[serde(other)]
Expand All @@ -147,9 +145,7 @@ impl FeatureSet {

/// Returns `true` if any spans are produced for this project.
pub fn produces_spans(&self) -> bool {
self.has(Feature::ExtractSpansFromEvent)
|| self.has(Feature::StandaloneSpanIngestion)
|| self.has(Feature::ExtractCommonSpanMetricsFromEvent)
self.has(Feature::ExtractSpansFromEvent) || self.has(Feature::StandaloneSpanIngestion)
}
}

Expand Down
3 changes: 1 addition & 2 deletions relay-dynamic-config/src/global.rs
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,7 @@ pub struct Options {
/// Overall sampling of span extraction.
///
/// This number represents the fraction of transactions for which
/// spans are extracted. It applies on top of [`crate::Feature::ExtractCommonSpanMetricsFromEvent`],
/// so both feature flag and sample rate need to be enabled to get any spans extracted.
/// spans are extracted.
///
/// `None` is the default and interpreted as a value of 1.0 (extract everything).
///
Expand Down
Loading
Loading