ref(quotas): Enforce span limits for transactions and vice versa #4963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/cache-inherited-rl-categories
branch
2 times, most recently
from
9f53b80 to
f2f16f3
Compare
Dav1dde
force-pushed
the
dav1d/cache-inherited-rl-categories
branch
from
f2f16f3 to
2d859b8
Compare
loewenheim
approved these changes
Jul 22, 2025
Comment on lines
+497
to
+498
| for i in 0..limit.categories.len() { | ||
| let Some(category) = limit.categories.get(i) else { |
There was a problem hiding this comment.
This is written with a loop over the index because of iterator invalidation?
There was a problem hiding this comment.
Correct, I cannot iterate and extend at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagates and enforces span rate limits for transactions in the fast path and vice versa.
This only implements the enforcement in the fast path and propagation, it does not implement the enforcement side for consistent rate limits. This is a different beast to implement and currently does not touch it, this to be done in a follow up.
For motivation and justification: https://develop.sentry.dev/ingestion/relay/transaction-span-ratelimits/
Refs: #4961