ref(spans): Always emit a usage metric #4976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/usage-span
branch
from
6e20f7c to
2f6998a
Compare
Dav1dde
force-pushed
the
dav1d/usage-span
branch
from
2f6998a to
4332efb
Compare
olksdr
approved these changes
Jul 29, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 29, 2025
Followup to: #4976, which added the usage metric metric extraction config, but metric extraction itself is also again hidden behind the `produces_spans()` flag. Removes the flag check for the generic span metric extraction. #skip-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always emit a Span usage metric. The idea is that we can give every customer an idea about their span volume, without having to 'blindly' upgrade to a plan which is span based.