ref(auth): add support for prehashed signature creation #5012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Litarnus
commented
Jul 31, 2025
|
|
||
| /// Used to tell which algorithm was used for signature creation. | ||
| #[derive(Default, Copy, Clone, Debug, Serialize, Deserialize, PartialEq, Eq)] | ||
| pub enum SignatureAlgorithm { |
There was a problem hiding this comment.
I couldn't think of a better name (SignatureType is used). Feel free to suggest a better name
There was a problem hiding this comment.
I think SignatureAlgorithm works fine.
Dav1dde
reviewed
Aug 1, 2025
loewenheim
approved these changes
Aug 1, 2025
Dav1dde
approved these changes
Aug 1, 2025
| } | ||
| SignatureAlgorithm::Prehashed => { | ||
| let digest = create_digest(&header, data); | ||
| self.inner.sign_digest(digest) |
There was a problem hiding this comment.
I guess nothing can go wrong, but this method panics silently (like sign before).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for pre-hashed signatures.
Currently we create signatures by cloning the passed data, which in some cases is the entire request body.
With pre-hashed signatures we can create the hash that is used in the signature process ourselves by incrementally digesting it.
Unfortunately, signatures creates by the two mentioned mechanisms are not compatible with each other.
Support for the new type is created by extending the signature header with informations about how the signature was created. To remain backwards compatible, it defaults to the old way of verifying signatures in case this information is missing.
To allow for a smooth rollout, only the verification is introduced in this PR and changing the creation will be done in a separate PR once this is sufficiently rolled out.
ref INGEST-430