ci(v8): Bump to ubuntu-24.04 #17507
Merged
ci(v8): Bump to ubuntu-24.04 #17507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
onurtemizkan
force-pushed
the
onur/v8-ubuntu-ci-bump
branch
from
9833224 to
6bbf9c2
Compare
onurtemizkan
force-pushed
the
onur/v8-ubuntu-ci-bump
branch
4 times, most recently
from
affde99 to
8c92ccb
Compare
onurtemizkan
force-pushed
the
onur/v8-ubuntu-ci-bump
branch
from
8c92ccb to
6c49c5c
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
s1gr1d
reviewed
Sep 11, 2025
| @@ -11,10 +11,4 @@ export default defineNuxtConfig({ | |||
| }, | |||
| }, | |||
| }, | |||
| nitro: { | |||
There was a problem hiding this comment.
Just a question: why was this deleted and the tests skipped?
This is deleted in newer versions of the SDK but it is here as kind of a "hack" to make the E2E tests work with the previous test setup, where we didn't create a temporary test folder.
There was a problem hiding this comment.
This nitro config was causing module resolution errors (except for nuxt-3-min: where there is another incompability due to mismatching of nuxt test suite). I didn't delve too deeply into debugging. But now unskipped tests, and they're passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unblocks backports to
v8branch, similarly to what's done for v7 (#17083)Summary:
size-check1.52.0