Skip to content

Fix some properties #3474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 29, 2024
Merged

Fix some properties #3474

merged 2 commits into from
Aug 29, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Aug 29, 2024 •
edited
Loading

  • add name
  • actually return op 🙈

Note: look like this makes tests stuck?

@codecov Codecov
Copy link

codecov bot commented Aug 29, 2024 •
edited
Loading

❌ 3905 Tests Failed:

Tests completed Failed Passed Skipped
16709 3905 12804 1916
View the top 3 failed tests by shortest run time 
tests.integrations.celery.test_celery test_simple_without_performance[<lambda>2]
Stack Traces | 0s run time 
No failure message available

tests.integrations.celery.test_celery test_transaction_events[<lambda>3-success]
Stack Traces | 0s run time 
No failure message available

tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_dbapi_spans_with_pii
Stack Traces | 0s run time 
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@sentrivana sentrivana merged commit e573d61 into potel-base Aug 29, 2024
9 of 97 checks passed
@sentrivana sentrivana deleted the ivana/potel/fix-some-properties branch August 29, 2024 14:00
@sentrivana sentrivana mentioned this pull request Aug 30, 2024
Draft
@BYK BYK mentioned this pull request Sep 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sentrivana @sl0thentr0py