Skip to content

Add custom sampling context testcases #4579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2025
Merged

Add custom sampling context testcases #4579

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a8dbe3
Add custom sampling context testcases
sentrivana Jul 14, 2025
64bcb87
naming
sentrivana Jul 14, 2025
e60fad4
cleanup
sentrivana Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 30 additions & 8 deletions tests/tracing/test_sampling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,16 +211,21 @@ def dummy_traces_sampler(sampling_context):
pass


def test_passes_attributes_from_start_span_to_traces_sampler(
sentry_init, DictionaryContaining # noqa: N803
):
traces_sampler = mock.Mock()
def test_passes_custom_attributes_in_sampling_context(sentry_init):
def traces_sampler(sampling_context):
assert sampling_context["dog.name"] == "Lily"
assert sampling_context["dog.activity"] == "fetch"
return 1.0

sentry_init(traces_sampler=traces_sampler)

with start_span(attributes={"dogs": "yes", "cats": "maybe"}):
traces_sampler.assert_called_once_with(
DictionaryContaining({"dogs": "yes", "cats": "maybe"})
)
with sentry_sdk.continue_trace(
{"sentry-trace": "12312012123120121231201212312012-1121201211212012-1"}
):
with sentry_sdk.start_span(
name="dogpark", attributes={"dog.name": "Lily", "dog.activity": "fetch"}
):
pass


def test_sample_rate_affects_errors(sentry_init, capture_events):
Expand Down Expand Up @@ -342,3 +347,20 @@ def dummy_profiles_sampler(sampling_context):
with sentry_sdk.continue_trace({"sentry-trace": sentry_trace}):
with sentry_sdk.start_span(name="dogpark", op="op"):
pass


def test_passes_custom_attributes_in_profiles_sampling_context(sentry_init):
def profiles_sampler(sampling_context):
assert sampling_context["dog.name"] == "Lily"
assert sampling_context["dog.activity"] == "fetch"
return 1.0

sentry_init(traces_sample_rate=1.0, profiles_sampler=profiles_sampler)

with sentry_sdk.continue_trace(
{"sentry-trace": "12312012123120121231201212312012-1121201211212012-1"}
):
with sentry_sdk.start_span(
name="dogpark", attributes={"dog.name": "Lily", "dog.activity": "fetch"}
):
pass
Loading