chore(profiling): Clean device classification code #82139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
viglia
approved these changes
Dec 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #82139 +/- ##
==========================================
- Coverage 80.36% 80.36% -0.01%
==========================================
Files 7277 7277
Lines 321487 321400 -87
Branches 20966 20966
==========================================
- Hits 258376 258301 -75
+ Misses 62703 62691 -12
Partials 408 408 |
phacops
deleted the
pierre/profiling-clean-device-classification-code
branch
evanh
pushed a commit
that referenced
this pull request
Dec 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now fetch the device classification from the transaction as it's determined by Relay.