feat(outcomes): Add file type to 'too large' outcome. #87078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
|
Please do not forget to update the doc with the exposed new reasons: https://docs.sentry.io/product/stats/#invalid 🙏 |
| 'Browser Extensions' | ||
| ); | ||
|
|
||
| expect(getReasonGroupName(Outcome.CLIENT_DISCARD, 'queue_overflow')).toBe( |
There was a problem hiding this comment.
we could reuse the enum ClientDiscardReason here too
There was a problem hiding this comment.
Just to make sure I understand this correctly, I changed this to (which required to export the ClientDiscardReason) I hope this was what you meant:
expect(getReasonGroupName(Outcome.CLIENT_DISCARD, 'queue_overflow')).toBe(
ClientDiscardReason.QUEUE_OVERFLOW
);
priscilawebdev
approved these changes
Mar 17, 2025
Co-authored-by: Priscila Oliveira <[email protected]>
Co-authored-by: Priscila Oliveira <[email protected]>
tobias-wilfert
changed the title
My attempt at updating the doc, feel free to leave comments on how it can be improved: getsentry/sentry-docs#13012 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to add the necessary logic to show more detail for the 'too large' outcome.
Since I am not a front-end wizzard it might be that I am missing something though.
Relay PR: getsentry/relay#4558
Fixes: https://github.com/getsentry/team-ingest/issues/635