tests : increase timeout when sanitizers are enabled #11300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
examples
python
ggerganov
force-pushed
the
gg/server-increase-timeout
branch
from
9d33e12 to
9d65a3d
Compare
ngxson
approved these changes
Jan 19, 2025
examples/server/tests/utils.py
Outdated
Comment on lines
91
to
93
| def start(self, timeout_seconds: int = 10) -> None: | ||
| if "LLAMA_SANITIZE" in os.environ: | ||
| timeout_seconds = 30 |
There was a problem hiding this comment.
Maybe doing this to limit LLAMA_SANITIZE to only control the default value:
DEFAULT_HTTP_TIMEOUT = 10 if "LLAMA_SANITIZE" not in os.environ else 30
Suggested change
| def start(self, timeout_seconds: int = 10) -> None: | |
| if "LLAMA_SANITIZE" in os.environ: | |
| timeout_seconds = 30 | |
| def start(self, timeout_seconds_: int | None = DEFAULT_HTTP_TIMEOUT) -> None: |
anagri
pushed a commit
to BodhiSearch/llama.cpp
that referenced
this pull request
Jan 26, 2025
* tests : increase timeout when sanitizers are enabled * tests : add DEFAULT_HTTP_TIMEOUT
tinglou
pushed a commit
to tinglou/llama.cpp
that referenced
this pull request
Feb 13, 2025
* tests : increase timeout when sanitizers are enabled * tests : add DEFAULT_HTTP_TIMEOUT
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Feb 26, 2025
* tests : increase timeout when sanitizers are enabled * tests : add DEFAULT_HTTP_TIMEOUT
mglambda
pushed a commit
to mglambda/llama.cpp
that referenced
this pull request
Mar 8, 2025
* tests : increase timeout when sanitizers are enabled * tests : add DEFAULT_HTTP_TIMEOUT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix https://github.com/ggerganov/llama.cpp/actions/runs/12855162878/job/35840541270#step:10:539