-
Notifications
You must be signed in to change notification settings - Fork 13.1k
ggml: WebGPU disable SET_ROWS for now #15078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…building/submission
Looks like it is still failing. |
Sorry this CI failure for WebGPU on the Linux machine is turning out to be trickier than I expected. I haven't been able to reproduce it locally yet, only on the Github action runners using the simulated Vulkan LLVMpipe backend. I'll keep working on it this week, to see if I can get a definitive answer into what's going on. In the meantime, would it make sense to just disable the WebGPU CI so it doesn't clutter up other PRs? |
Looks like the CI is passing now, I was able to debug on the Github action runner using this: https://github.com/mxschmitt/action-tmate. I believe the issue was due to not blocking on I also made another minor changes in this PR, to explicitly wait on A few of the macOS CI tests are still queued, I'll wait for them to complete successfully before merging. Hopefully the WebGPU CI is more stable from here on! |
test-thread-safety was recently updated to use SET_ROWS by default, but the WebGPU backend doesn't support it yet. I'm aiming to add support and open a PR in the next couple days, but in the meantime disabling SET_ROWS for the CI so the WebGPU tests pass.