Golang Bindings Error

[mbaxamb3333]

I would like to start by saying a big thank you for all the work that you put into maintaining and developing this project.
My issue is with regards to the golang bindings.
As I try to initialise the model, I get the following error.

../go/pkg/mod/github.com/ggerganov/whisper.cpp/bindings/go@v0.0.0-20230116195735-49b529ba74f3/params.go:11:10: fatal error: 'whisper.h' file not found
#include <whisper.h>

Does anyone has any idea why this might happen?

[mbaxamb3333]

The same thing happens when I try to run the whisper_test file.

Running tool: /opt/homebrew/bin/go test -timeout 30s -coverprofile=/var/folders/y0/dbsx2zd55lz31wt__nmdgm840000gn/T/vscode-goJry90s/go-code-cover github.com/ggerganov/whisper.cpp/bindings/go

github.com/ggerganov/whisper.cpp/bindings/go

/var/folders/y0/dbsx2zd55lz31wt__nmdgm840000gn/T/go-build3341714362/b084/params.cover.go:11:10: fatal error: 'whisper.h' file not found
#include <whisper.h>
^~~~~~~~~~~
1 error generated.
FAIL github.com/ggerganov/whisper.cpp/bindings/go [build failed]
FAIL

[mbaxamb3333]

When I run the tests from the make file everything works fine, whilst when I run the package test, it fails with the error above

[mbaxamb3333]

[ggerganov]

I believe this has been resolved at some point.
Feel free to reopen if problem persists

[jaybinks]

*mbaxamb3333* This typically means you need to tell the go compiler where your whisper.cpp files are located. Try setting these environment variables export CGO_CFLAGS=-I/path/to/whisper.cpp/ export CGO_LDFLAGS=-L/path/to//whisper.cpp/

…

On Thu, 16 Feb 2023 at 04:38, Georgi Gerganov ***@***.***> wrote: I believe this has been resolved at some point. Feel free to reopen if problem persists — Reply to this email directly, view it on GitHub <#418 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALQR6YJHPDHVD4JYZ6MEL3WXUPDPANCNFSM6AAAAAAT5Q73H4> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- Sincerely Jay

[hemant-saikia]

@jaybinks Do we not have to tell compiler to look into the include/ subdirectory in whisper.cpp

@ggerganov
INCLUDE_PATH and LIBRARY_PATH in bindings/go/Makefile refer to the parent folder, but the whisper.h file and ggml.h files are in whisper.cpp/include/ and whisper.cpp/ggml/include folders respectively.

Isn't that why the missing .h file error pops up. Do we need to update the Makefile? Or copy the .h files to parent dir.

fatal error: 'whisper.h' file not found
#include <whisper.h>

What am I missing here?

[ggerganov]

Yes, likely caused by the recent #2256. Feel free to open a PR with fixes

[byoungdale]

I started working on this issue. I have a draft pull request #2376. I got the issue with the changed paths to the header files fixed, but I am still getting errors with ggml symbols:

  "_ggml_view_tensor", referenced from:
      whisper_build_graph_encoder(whisper_context&, whisper_state&) in libwhisper.a[2](whisper.o)
      whisper_build_graph_cross(whisper_context&, whisper_state&) in libwhisper.a[2](whisper.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

make: *** [examples/go-whisper] Error 1

This is not the whole output. Just the end. I will keep taking a look when I can. But, wanted to put here in case anyone else made a better idea more quickly.

[9nut]

This is my HACK to get past this and verify it works.

diff --git a/bindings/go/Makefile b/bindings/go/Makefile
index 4f3a416..1480a59 100644
--- a/bindings/go/Makefile
+++ b/bindings/go/Makefile
@@ -14,11 +14,11 @@ GGML_METAL_PATH_RESOURCES := $(abspath ../..)
 BUILD_DIR := build
 MODELS_DIR := models
 EXAMPLES_DIR := $(wildcard examples/*)
-INCLUDE_PATH := $(abspath ../..)
-LIBRARY_PATH := $(abspath ../..)
+INCLUDE_PATH := $(abspath ../../include):$(abspath ../../ggml/include)
+LIBRARY_PATH := $(abspath ../../)
 
 ifeq ($(UNAME_S),Darwin)
-       EXT_LDFLAGS := -framework Foundation -framework Metal -framework MetalKit
+       EXT_LDFLAGS := -framework Foundation -framework Metal -framework MetalKit -framework Accelerate $(wildcard ../../ggml/src/ggml*.o)
 endif
 
 all: clean whisper examples

[AMDphreak]

I would like to start by saying a big thank you for all the work that you put into maintaining and developing this project. My issue is with regards to the golang bindings. As I try to initialise the model, I get the following error.

../go/pkg/mod/github.com/ggerganov/whisper.cpp/bindings/go@v0.0.0-20230116195735-49b529ba74f3/params.go:11:10: fatal error: 'whisper.h' file not found #include <whisper.h>

Does anyone has any idea why this might happen?

I managed to work around this problem with environment variables. This is the cleanest solution I can think of for us downstream devs.

Drop this into a script setvars.ps1 and run it in your project's directory:

$env:CGO_CFLAGS="-I$PWD/whisper.cpp/include -I$PWD/whisper.cpp/ggml/include"
$env:CGO_LDFLAGS="-L$PWD/whisper.cpp/build/bin/Release -lwhisper"

I DO NOT copy whisper.h or libwhisper.a to my project. I find that hack to be less palatable. Pulling things out of context and having to remember to keep track of this stuff is not a good idea.

I don't understand why this issue is closed. It still happens for anyone using the bindings.