all: build using Go 1.8 #1952
Merged
all: build using Go 1.8 #1952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technoweenie
approved these changes
Feb 17, 2017
|
Does it really make sense to jump at new Go versions immediately after their release? Waiting for the next minor release (like 1.8.1) would have the benefit of getting additional fixes for bugs that were rushed out with the release, and we'd have a higher chance of the release being available as a Chocolatey package. |
|
I think testing with the new version is good. Though we probably could've held off on updating the appveyor build until it's available on chocolatey. We're not releasing LFS 2.0 for at least a week, so we still have time to evaluate go 1.8. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request upgrades our testing infrastructure to use Go 1.8.
.travis.ymlto use 1.8.cinstyet, so let's install it ourselves./cc @git-lfs/core