fail dedup command with explanation when LFS extensions configured #4045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dedup command should not proceed if any Git LFS extensions are configured, because these typically will change the contents of the file (e.g., by compression) which is written to the local LFS object storage tree from what the user expects to see in their working tree, and so the working tree files should not be cloned (via filesystem reflinks) from the object storage files.
We note in our docs for the dedup command that it will refuse to de-duplicate the working tree if any Git LFS extensions are configured, as these have likely caused the object storage files to differ from what the user expects in their working tree (e.g., by compression).
Add tests for both the bare and -t flavours of "git lfs dedup" to confirm that having any registered Git LFS extensions cause the command to exit with the expected warning message.
bk2204
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add checks to the
git lfs dedupcommand and its-ttest option variant which cause the command to exit immediately with an explanatory message if any Git LFS extensions are configured.This is because extensions normally cause the LFS storage object files to be altered in some way (for example, by compressing them), and so the object storage files can not be used as one-to-one copy-on-write clones (via filesystem reflinks) in the working tree, or else users would see unexpected file contents.
Fixes #4043.
/cc @swisspol as reporter