Add error handling for missing GitHub token and explicitly stating VUE_APP_MOCKED_DATA=true in the UI #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…E_APP_MOCKED_DATA=true in the UI
martedesco
reviewed
May 23, 2024
martedesco
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on improving the handling of environment variables in the
GitHubApi.tsandMainComponent.vuefiles. The changes include adding a console log to notify when mock data is being used, throwing an error when theVUE_APP_GITHUB_TOKENenvironment variable is not set, and displaying a message on the main component when mock data is being used.User Feedback Enhancements:
src/api/GitHubApi.ts: Added a console log to inform the developer when the application is using mock data.src/components/MainComponent.vue: Added a dynamic error message to the main component's UI to inform the user when the application is using mock data. [1] [2]Error Handling Improvements:
src/api/GitHubApi.ts: Added error handling to throw an error when theVUE_APP_GITHUB_TOKENenvironment variable is not set. This prevents the application from making API calls without the necessary authentication token.