Skip to content

Conversation

datanerd
Copy link

This pull request primarily focuses on refactoring the CSS styles and HTML structure of various Vue components in the project. The changes are mainly centered around the extraction of common styles to a global CSS file and the adjustment of HTML structure and class assignments to better use these styles.

CSS Centralization:

  • src/assets/global.css: Added new CSS classes .tiles-container, .tiles-text, and .error-message for common styling across different components.
  • src/main.ts: Imported the global.css file to make the CSS classes available globally across the application.

CSS Removal:

HTML Structure Refactoring:

  • src/components/BreakdownComponent.vue: Applied the .tiles-text CSS class to the appropriate div elements and modified the paragraph (p) elements to use the .text-h4 class for styling.
  • src/components/CopilotChatViewer.vue: Applied the .tiles-text CSS class to the appropriate div elements and modified the paragraph (p) elements to use the .text-h4 class for styling.
  • src/components/MetricsViewer.vue: Applied the .tiles-text CSS class to the appropriate div elements and modified the paragraph (p) elements to use the .text-h4 class for styling.
  • src/components/SeatsAnalysisViewer.vue: Applied the .tiles-text CSS class to the appropriate div elements, modified the v-card-item to use the .d-flex, .justify-center, and .align-center classes for styling, and modified the paragraph (p) elements to use the .text-h4 class for styling.

@datanerd
Copy link
Author

Don't know how to center a text that spans across two lines :( Any ideas?
image

@AdrianDsg
Copy link
Contributor

AdrianDsg commented Jun 14, 2024

Hi @andrekolodochka,
Thanks for your contributions to this project. I'm glad that the involvement of hubbers in this project is growing.

Don't know how to center a text that spans across two lines :( Any ideas?

Probably I'm missing something but I think using the CSS text-align: center; might work for you.

Regards,
Adrian

@datanerd
Copy link
Author

datanerd commented Jun 14, 2024

Probably I'm missing something but I think using the CSS text-align: center; might work for you.

🤦 🤦 🤦
fixed.

@martedesco
Copy link
Collaborator

Thanks so much for the so due refactoring!

I am adding some spacing in the cards so the two-liners are centralized. Looking like below

image

@martedesco martedesco merged commit ad7fc7f into github-copilot-resources:main Jun 20, 2024
@datanerd datanerd deleted the formatting branch June 22, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants