Externalize config from Docker image #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karpikpl
approved these changes
Jun 25, 2024
Closed
|
Any ETA on approving this? |
|
bump.... @karpikpl / @martedesco |
|
@dcieslak19973 I merged this PR into mine #55 and resolved conflicts but I have no control when it will be merged by @DevOps-zhuang |
|
Thanks! I was in holidays for a while. I will review it and merge it this week 👍🏼 |
|
Just to be clear - this PR fixes the env. variables but token is still hardcoded and exposed. I would not recommend deploying this to AKS or any production-like environment. #55 is trying to mitigate it by keeping the token server side (not in the browser) |
martedesco
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #30
This pull request includes significant changes to the Docker configuration and the way the application handles environment variables. The most important changes are the addition of a
.dockerignorefile, updates to theDockerfile, and the creation of a newconfig.tsfile that handles environment variables differently depending on whether the application is in production or development mode. The application's Vue components and API calls have also been updated to use this new configuration file.