Skip to content

Conversation

byt3n33dl3
Copy link

@byt3n33dl3 byt3n33dl3 commented Aug 19, 2025

Updates

  • CWEs
  • References

Comments
Adding References based on my GHSA Mermaid's bundled version of DOMPurify for Prototype Pollution

@github
Copy link
Collaborator

github commented Aug 19, 2025

Hi there @EvanHahn! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.

This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

@Copilot Copilot AI review requested due to automatic review settings August 19, 2025 05:21
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates a GitHub Security Advisory (GHSA-w2cq-g8g3-gm83) for a prototype pollution vulnerability in the content-security-policy-parser package by adding additional metadata and references.

  • Updates the modified timestamp to reflect the changes
  • Adds an additional CWE identifier (CWE-1395) to complement the existing CWE-1321
  • Includes a reference to another related advisory (GHSA-m4gq-x24j-jpmf) for prototype pollution context

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot changed the base branch from main to byt3n33dl3/advisory-improvement-6026 August 19, 2025 05:22
@@ -1,7 +1,7 @@
{
"schema_version": "1.4.0",
"id": "GHSA-w2cq-g8g3-gm83",
"modified": "2025-08-12T19:19:42Z",
"modified": "2025-08-12T19:19:44Z",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be changed to a more recent time?

{
"type": "PACKAGE",
"url": "https://github.com/helmetjs/content-security-policy-parser"
}
],
"database_specific": {
"cwe_ids": [
"CWE-1321"
"CWE-1321",
"CWE-1395"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think CWE-1395 applies here. I think that refers to vulnerable dependencies, which was unrelated to this issue.

Comment on lines +55 to +58
{
"type": "ADVISORY",
"url": "https://github.com/advisories/GHSA-m4gq-x24j-jpmf"
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this related?

Copy link

github-actions bot commented Sep 5, 2025

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the Keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot. Please see CONTRIBUTING.md for more policy details.

@github-actions github-actions bot added the Stale label Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants