-
Notifications
You must be signed in to change notification settings - Fork 54
Closed
github/combobox-nav
#10Description
After PR #15 the combobox no longer scrolls when navigating with the arrow keys.
I've made a small example here https://auto-complete-scroll.glitch.me it is the example from this repo, but where I've added a height: 45px; overflow-y: auto;
styling to the ul
element.
The problem is that the select method in autocomplete.js
is no longer called when navigating, so the scrollTo
function is never called.
It can be fixed by either moving the scroll functionality to the combobox-nav project instead, or have the combo-box fire an combobox-navigation
event and then listen for that and perform the necessary scrolling.
If one of the proposed methods are suitable, I can submit a PR.
Metadata
Metadata
Assignees
Labels
No labels