Skip to content

add support for popovers #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2023
Merged

add support for popovers #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b207c87
add support for popovers
keithamus Nov 13, 2023
c240d6e
install latest playwright on test
keithamus Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions examples/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
<input name="robot" type="text" aria-labelledby="robots-label" autofocus />
<!-- if a clear button is passed in, recommended to be *before* UL elements to avoid conflicting with their blur logic -->
<button id="robot-clear">x</button>
<ul id="items-popup"></ul>
<ul popover id="items-popup"></ul>
<!-- For built-in screen-reader announcements:
- Note the ID is the same as the <ul> with "feedback" appended
- Also note that aria attributes will be added programmatically if they aren't set correctly
Expand All @@ -64,7 +64,7 @@
<input id="robot-a" name="robot-a" type="text" aria-labelledby="robots-a-label" autofocus />
<!-- if a clear button is passed in, recommended to be *before* UL elements to avoid conflicting with their blur logic -->
<button id="robot-a-clear">x</button>
<ul id="items-a-popup"></ul>
<ul popover id="items-a-popup"></ul>
<!-- For built-in screen-reader announcements:
- Note the ID is the same as the <ul> with "feedback" appended
- Also note that aria attributes will be added programmatically if they aren't set correctly
Expand All @@ -79,7 +79,7 @@
<label id="robots-2-label" for="robot-2">Robots (without autoselect on enter)</label>
<auto-complete src="/demo" for="items-2-popup" aria-labelledby="robots-2-label">
<input name="robot-2" type="text" aria-labelledby="robots-2-label" autofocus />
<ul id="items-2-popup"></ul>
<ul popover id="items-2-popup"></ul>
<div id="items-2-popup-feedback" class="sr-only"></div>
</auto-complete>
<button type="submit">Save</button>
Expand All @@ -88,9 +88,15 @@
<!-- example with a custom fetching result method -->
<form>
<label id="custom-fetching-robots-label" for="custom-fetching-robot">Custom Fetching Robots</label>
<auto-complete id="custom-fetching-method" src="/demo" for="custom-fetching-items-popup" aria-labelledby="custom-fetching-robots-label" data-autoselect="true">
<input name="custom-fetching-robot" type="text" aria-labelledby="custom-fetching-robots-label" autofocus>
<ul id="custom-fetching-items-popup"></ul>
<auto-complete
id="custom-fetching-method"
src="/demo"
for="custom-fetching-items-popup"
aria-labelledby="custom-fetching-robots-label"
data-autoselect="true"
>
<input name="custom-fetching-robot" type="text" aria-labelledby="custom-fetching-robots-label" autofocus />
<ul popover id="custom-fetching-items-popup"></ul>
<div id="custom-fetching-items-popup-feedback" class="sr-only"></div>
</auto-complete>
<button type="submit">Save</button>
Expand All @@ -107,7 +113,7 @@
<auto-complete src="/demo" for="fetch-on-empty-items-popup" aria-labelledby="fetch-on-empty-robots-label" fetch-on-empty>
<input name="fetch-on-empty-robot" type="text" aria-labelledby="fetch-on-empty-robots-label" autofocus />
<button id="fetch-on-empty-robot-clear">x</button>
<ul id="fetch-on-empty-items-popup"></ul>
<ul popover id="fetch-on-empty-items-popup"></ul>
<div id="fetch-on-empty-items-popup-feedback" class="sr-only"></div>
</auto-complete>
<button type="submit">Save</button>
Expand Down
Loading