Skip to content

remove disabled attribute from aria-hidden no-result-found example #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2025
Merged

remove disabled attribute from aria-hidden no-result-found example #130

merged 2 commits into from
Mar 10, 2025

Conversation

jdanyow
Copy link
Contributor

@jdanyow jdanyow commented Feb 25, 2025

No description provided.

@jdanyow jdanyow requested a review from a team as a code owner February 25, 2025 22:14
@francinelucca
Copy link
Contributor

Can you add some context as to why this change is needed @jdanyow ? 🙏

@jdanyow
Copy link
Contributor Author

jdanyow commented Mar 8, 2025

I believe the author made a typo. You cannot disable an li element

@francinelucca francinelucca merged commit f4ab7a1 into github:main Mar 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francinelucca francinelucca francinelucca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdanyow @francinelucca