Skip to content

Conversation

mbg
Copy link
Member

@mbg mbg commented Sep 2, 2025

Extracted from #3064. Fixes some incorrect properties in createTestConfig.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg requested a review from a team as a code owner September 2, 2025 12:29
@Copilot Copilot AI review requested due to automatic review settings September 2, 2025 12:29
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes inconsistencies in the createTestConfig function by adding missing properties and correcting property types to match the actual Config interface. The changes ensure the test configuration object properly reflects the structure of production configurations.

  • Adds missing overlay database properties (overlayDatabaseMode and useOverlayDatabaseCaching)
  • Corrects the type of dependencyCachingEnabled from boolean to CachingKind.None
  • Adds explicit type casting to ensure type safety

Co-authored-by: Esben Sparre Andreasen <[email protected]>
@mbg mbg enabled auto-merge September 2, 2025 12:47
@mbg mbg merged commit 68d7fe3 into main Sep 2, 2025
278 checks passed
@mbg mbg deleted the mbg/fix/createTestConfig branch September 2, 2025 12:56
@github-actions github-actions bot mentioned this pull request Sep 5, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants