Skip to content

Conversation

mbg
Copy link
Member

@mbg mbg commented Sep 2, 2025

Extracted from #3064 to facilitate unblock removing AugmentationProperties from Config in a follow-up PR.

The quality-queries input will be removed in favour of analysis-kinds. Internally, we have already only used quality-queries with code-quality as argument, so hard-coding this here does not make a difference right now.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg requested a review from henrymercer September 2, 2025 16:33
@mbg mbg requested a review from a team as a code owner September 2, 2025 16:33
@Copilot Copilot AI review requested due to automatic review settings September 2, 2025 16:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated quality-queries input by hard-coding the code quality queries to use ["code-quality"]. This is part of a larger effort to remove AugmentationProperties from Config and transition users to the analysis-kinds input instead.

Key changes:

  • Deprecation warning added for the quality-queries input
  • Hard-coded quality queries to ["code-quality"] instead of using the input parameter
  • Removed qualityQueriesInput from configuration interfaces and processing logic

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/init-action.ts Adds deprecation warning for quality-queries input and passes it to config initialization
src/config-utils.ts Removes qualityQueriesInput from AugmentationProperties and calculateAugmentation function
src/config-utils.test.ts Updates tests to remove quality-queries parameter from test cases
src/analyze.ts Replaces quality queries input with hard-coded code-quality queries from analyses module
src/analyses.ts Adds hard-coded codeQualityQueries constant
init/action.yml Updates quality-queries input description to indicate deprecation

@mbg mbg merged commit 9f5a64c into main Sep 2, 2025
278 checks passed
@mbg mbg deleted the mbg/cq/hardcode-quality-queries branch September 2, 2025 17:00
@github-actions github-actions bot mentioned this pull request Sep 5, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants