Skip to content

Conversation

mbg
Copy link
Member

@mbg mbg commented Sep 4, 2025

This allows git_source registry configurations for Go.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg requested a review from a team as a code owner September 4, 2025 14:09
@Copilot Copilot AI review requested due to automatic review settings September 4, 2025 14:09
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for git_source registry configurations for the Go language in the CodeQL Action's start-proxy functionality. This allows Go projects to use Git-based sources in addition to the existing goproxy_server registry type.

Key Changes

  • Modified the language-to-registry-type mapping to support multiple registry types per language
  • Updated Go language to accept both goproxy_server and git_source registry types
  • Added comprehensive test coverage for the new multi-registry functionality

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/start-proxy.ts Updated LANGUAGE_TO_REGISTRY_TYPE to support arrays of registry types and modified credential filtering logic to handle multiple types per language
src/start-proxy.test.ts Added test cases to verify Go language accepts both goproxy_server and git_source registry types, and refactored existing tests to use shared test data
lib/start-proxy-action.js Generated JavaScript file (no review needed per guidelines)

@mbg mbg merged commit 2d2f57e into main Sep 4, 2025
278 checks passed
@mbg mbg deleted the mbg/proxy/accept-git-source branch September 4, 2025 15:57
@github-actions github-actions bot mentioned this pull request Sep 5, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants