Skip to content

Conversation

robertbrignull
Copy link
Contributor

This PR adds a check to the multi-language-repo_test-autodetect-languages test that the expected number of databases were created. Currently we don't check anything except that it didn't crash. We could go even further and check

Here's an example of it failing: https://github.com/github/codeql-action/runs/685732844?check_suite_focus=true

Also only runs that test on one OS as I don't think running it on windows too is testing anything useful. We have other tests that run on all supported OSes. This should make the integration tests a tiny bit faster.

Merge / deployment checklist

  • Run test builds as necessary. Can be on this repository or elsewhere as needed in order to test the change - please include links to tests in other repos!
    • CodeQL using init/analyze actions
    • 3rd party tool using upload action
  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

@robertbrignull
Copy link
Contributor Author

@Daverlo, do you have time to review this?

@robertbrignull robertbrignull merged commit 28a878e into master Jun 1, 2020
@robertbrignull robertbrignull deleted the integration_test_check branch June 1, 2020 10:28
@robertbrignull robertbrignull mentioned this pull request Jun 1, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants