Skip to content

Add back retrying. #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 7, 2021
Merged

Add back retrying. #547

merged 3 commits into from
Jun 7, 2021

Conversation

chrisgavin
Copy link
Contributor

I think 81a21bf accidentally removed Octokit retrying. This adds the retrying back to handle transient network errors.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

edoardopirovano
edoardopirovano approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@edoardopirovano edoardopirovano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though it looks like you need to update a unit test

@chrisgavin chrisgavin enabled auto-merge June 7, 2021 06:47
@chrisgavin chrisgavin merged commit 242fd82 into main Jun 7, 2021
@chrisgavin chrisgavin deleted the retrying-fix branch June 7, 2021 07:04
@github-actions github-actions bot mentioned this pull request Jun 7, 2021
Merged
5 tasks
@chrisjcox79 chrisjcox79 mentioned this pull request Jun 20, 2023
Open
@aliscco aliscco mentioned this pull request Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

+1 more reviewer

@edoardopirovano edoardopirovano edoardopirovano approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisgavin @aeisenberg @edoardopirovano