Skip to content

JavaScript 1.22: Finalize release notes #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 24, 2019
Merged

JavaScript 1.22: Finalize release notes #1816

merged 3 commits into from
Aug 24, 2019

Conversation

felicitymay
Copy link
Contributor

This PR adds query ids where they were missing and makes a few small text changes.

@Semmle/js - is there anything missing from this?

@felicitymay felicitymay added JS documentation Priority PR that should be reviewed and merged as a matter of priority. labels Aug 24, 2019
@felicitymay felicitymay added this to the 1.22 milestone Aug 24, 2019
@asger-semmle
Copy link
Contributor

Hang on, there's one more change note I'd like to get in. I'll open a PR against this PR.

@felicitymay
Copy link
Contributor Author

Thanks @asger-semmle

asger-semmle
asger-semmle approved these changes Aug 24, 2019
View reviewed changes
Copy link
Contributor

@asger-semmle asger-semmle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@semmle-qlci semmle-qlci merged commit e37751e into github:master Aug 24, 2019
@felicitymay felicitymay deleted the 1.22/js-finalize-change-notes branch September 23, 2019 16:32
@felicitymay felicitymay restored the 1.22/js-finalize-change-notes branch September 23, 2019 16:32
@felicitymay felicitymay deleted the 1.22/js-finalize-change-notes branch September 23, 2019 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@asger-semmle asger-semmle asger-semmle approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation JS Priority PR that should be reviewed and merged as a matter of priority.
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
3 participants
@felicitymay @asger-semmle @semmle-qlci